Xetibo/DashNix
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity Actions

Add lib.mkDefault for non configurable defaults #15

Merged
DashieTM merged 1 commit from mkDefault into main 2025-05-09 23:27:37 +02:00
Conversation 5 Commits 1 Files changed 8 +82 -70
DashieTM commented 2025-05-09 12:06:25 +02:00 (Migrated from github.com)
Copy link

should fix: https://github.com/Xetibo/DashNix/issues/14

--- should fix: https://github.com/Xetibo/DashNix/issues/14
DashieTM commented 2025-05-09 12:06:47 +02:00 (Migrated from github.com)
Copy link

waiting for response before merging.

waiting for response before merging.
thomas-zahner (Migrated from github.com) reviewed 2025-05-09 14:57:01 +02:00
lib/override.nix
@ -0,0 +1 @@
{lib, ...}: value: lib.mkOverride 999 value
thomas-zahner (Migrated from github.com) commented 2025-05-09 14:57:01 +02:00
Copy link

999 means it has a very low precedence?

`999` means it has a very low precedence?
thomas-zahner (Migrated from github.com) approved these changes 2025-05-09 14:59:03 +02:00
thomas-zahner (Migrated from github.com) left a comment
Copy link

Looks good to me

Looks good to me
DashieTM (Migrated from github.com) reviewed 2025-05-09 15:00:03 +02:00
lib/override.nix
@ -0,0 +1 @@
{lib, ...}: value: lib.mkOverride 999 value
DashieTM (Migrated from github.com) commented 2025-05-09 15:00:03 +02:00
Copy link

yes, mkDefault is 1000, but that would conflict with the NixOS default, hence I use 1 below to create a new "default".
Did you test it?

yes, mkDefault is 1000, but that would conflict with the NixOS default, hence I use 1 below to create a new "default". Did you test it?
thomas-zahner (Migrated from github.com) reviewed 2025-05-09 15:12:31 +02:00
lib/override.nix
@ -0,0 +1 @@
{lib, ...}: value: lib.mkOverride 999 value
thomas-zahner (Migrated from github.com) commented 2025-05-09 15:12:31 +02:00
Copy link

Ah that makes sense. Not yet.

Ah that makes sense. Not yet.
Sign in to join this conversation.
Reviewers
No reviewers
thomas-zahner
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Xetibo/DashNix#15
No description provided.
Delete branch "mkDefault"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?